vscode-reveal icon indicating copy to clipboard operation
vscode-reveal copied to clipboard

`data-background-transition` not working

Open rleyvasal opened this issue 2 years ago • 10 comments

revealjs example shows how the background transition should work; however, setting the following code in vscode-reveal does not produce the desired effect.

---
theme : "white"
transition: "slide"
slideNumber: false
---

## first slide

---

## second slide

<!-- .slide: data-background="#43464B" data-background-transition="zoom" -->

## Background Transitions

Different background transitions are available via the backgroundTransition option. This one's called "zoom".


rleyvasal avatar May 13 '22 17:05 rleyvasal

do it like this



## first slide

---

<!-- .slide: data-background="#43464B" data-transition="zoom" -->

## second slide

evilz avatar May 18 '22 07:05 evilz

Thanks, I can confirm it works.

rleyvasal avatar May 25 '22 21:05 rleyvasal

how can i use different animations for data and the background? Is this already possible by this vscode extension?

<!-- .slide: data-transition="slide" data-background="#4d7e65" data-background-transition="zoom" -->

Sebbstar avatar Jul 13 '22 17:07 Sebbstar

It should works

evilz avatar Jul 14 '22 18:07 evilz

can you confirm that this minimal example works for you? I tested it in multiple browsers and vs code preview window

<!-- .slide: data-transition="slide" data-background="#4d7e65" data-background-transition="zoom" -->

# Page1

---

<!-- .slide: data-transition="slide" data-background="#fd7e65" data-background-transition="slide" -->

## Page2

i'm using vscode-reveal v4.3.3

Version: 1.70.0-insider (user setup) Commit: e0a65a97d4f349cf11a7cae804a5553ccb412528 Date: 2022-07-14T05:17:15.290Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.22000

also on a clean installation of: Version: 1.69.1 (user setup) Commit: b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a Date: 2022-07-12T08:21:24.514Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.22000

data transition are working perfectly. but all background transitions do not work also the parallaxBackground transitions. Using reveal-md the background transitions do work but i would prefer using your extension.

Sebbstar avatar Jul 15 '22 07:07 Sebbstar

i tracked the error down to init.js

      const plugins =  [...printPlugins,
      <% if(enableZoom) {%>RevealZoom, <%}%>
      <% if(enableSearch) {%>RevealSearch, <%}%>
          RevealMarkdown, 
          <% if(enableMenu) {%>RevealMenu, <%}%>
          RevealFullscreen,
          RevealAnything,
          //RevealAudioSlideshow,
          //RevealAudioRecorder,
          <% if(enableMenu) {%>RevealCustomControls, <%}%>
          // poll
          // question
          // seminar
          Verticator 
           ]

without the RevealFullscreen plugin background animations are working perfectly.

Sebbstar avatar Jul 15 '22 08:07 Sebbstar

Maybe I should remove this plugin

evilz avatar Jul 17 '22 15:07 evilz

Fullscreen plugin is very helpful, if a workaround can be found, it would be preferable

rleyvasal avatar Jul 17 '22 15:07 rleyvasal

I tried to modify plugin.js from the fullscreen plugin and disabled line 36 Reveal.configure( config ); The result looks good for me but i am not very family with reeal.js and any of its plugins.

Sebbstar avatar Jul 18 '22 06:07 Sebbstar

Ok issue already exists here https://github.com/rajgoel/reveal.js-plugins/issues/107 It should be fix here.

evilz avatar Jul 18 '22 07:07 evilz