vscode-reveal icon indicating copy to clipboard operation
vscode-reveal copied to clipboard

4.0.2 not recognizing notes

Open fuhrmanator opened this issue 4 years ago • 8 comments

The Note: separator which used to work (3.4.x?) does not work in 4.0.2:

<!-- .slide: data-separator-notes="^Note:" -->

# Title

- blah

Note: Here's a note

In 3.4.x (?) I think I was using the vscode setting:

"revealjs.notesSeparator": "^Note:"

In any case, it was working. Now it's not.

A work-around now is to wrap the note in <aside class="notes"> (is not shown, and shows in speaker notes):

<aside class="notes">Note: Here's a note</aside>

fuhrmanator avatar Sep 24 '19 22:09 fuhrmanator

😅 I 'd forgetten to parse it

evilz avatar Sep 25 '19 04:09 evilz

Hmm looks like the new version (4.0.3) is already installed on my machine but it still doesn't work. Am I probably missing something?

orgi avatar Oct 23 '19 15:10 orgi

Looks like I got it wrong. Instead of writing

note: Some note

I tried to use it like:

note:
* First note line
* Second note line
* ...

Somehow multi-line notes don't seem to be supported without using HTML. Any plans to support that?

orgi avatar Oct 23 '19 16:10 orgi

In my settings, it's

"revealjs.notesSeparator": "^Note:"

I think it would be case-sensitive (meaning you have to have Note: and not note:.

Either way, it's still not working in my 4.0.3 install on Windows 10.

fuhrmanator avatar Oct 23 '19 18:10 fuhrmanator

I tried playing more with it and got this to work:

notesSeparator: "Note:"

But as @orgi pointed out, it won't work for multi-line notes. Bullets (from markdown) in notes are very useful.

fuhrmanator avatar Mar 02 '20 23:03 fuhrmanator

@evilz any chance to get this working with multi-line markdown, as discussed at https://github.com/evilz/vscode-reveal/issues/295#issuecomment-545516608

fuhrmanator avatar Mar 07 '21 17:03 fuhrmanator

Multiline notes are working within the aside tag. You need to set the data-markdown attribute and for some reason you cannot have blank lines within the aside tag.

<aside class="notes" data-markdown="">
my comment
<!-- NO BLANK LINES -->
- item1
- item2
  - item 2.a
  - item 2.b
- item 3
<br>
more comments
</aside>

klezm avatar Jan 16 '22 12:01 klezm

You are right. Need to remake all parser for the note.

Actually you can add <br/> to go to new line.

If someone want to code the note parser I took it :p

evilz avatar Jan 16 '22 12:01 evilz