ember-performance icon indicating copy to clipboard operation
ember-performance copied to clipboard

link-to rendered benchmark failing on Ember 2.6

Open GCheung55 opened this issue 8 years ago • 2 comments

https://github.com/eviltrout/ember-performance/blob/master/benchmarks/link-to/rendered/index.js#L35 is causing the test to fail.

I've tried using LinkComponent, if LinkView is falsey, but get errors about lookup:

Uncaught TypeError: Cannot read property 'lookup' of undefined
    at Class.injectedPropertyGet (ember-2.6.0.prod.js:15712)
    at InjectedProperty.ComputedPropertyPrototype.get (ember-2.6.0.prod.js:13565)
    at get (ember-2.6.0.prod.js:19152)
    at _getPath (ember-2.6.0.prod.js:19173)
    at Object.get (ember-2.6.0.prod.js:19148)
    at Class.computeLinkToComponentActive (ember-2.6.0.prod.js:28840)
    at ComputedPropertyPrototype.get (ember-2.6.0.prod.js:13565)
    at Object.get (ember-2.6.0.prod.js:19152)
    at Class.get (ember-2.6.0.prod.js:33710)
    at Benchmark.uid1485309390008createFunction [as compiled] (<anonymous>:22:18)

GCheung55 avatar Jan 25 '17 02:01 GCheung55

Yeah that test seems quite broken. Maybe we should just remove it?

Were you looking to specifically benchmark this?

eviltrout avatar Jan 26 '17 18:01 eviltrout

I wasn't testing specific. I just wanted to get some numbers between 2.6 and 2.10 since that's what my upgrade path looked like.

GCheung55 avatar Jan 26 '17 23:01 GCheung55