markdown-js icon indicating copy to clipboard operation
markdown-js copied to clipboard

Published 20 hours ago • verified publisher icon evilstreak

FIX: Error when linking to absolute URLs with absolute links to images

Open eviltrout opened this issue 10 years ago • 4 comments

Matching URLs with regular expressions is tough! However, this approach fixes issues when linking to absolute URLs with absolute image URLs inside them.

eviltrout avatar Jul 29 '14 16:07 eviltrout

At times I wish I hadn't built this around regexps :( That :ship: has long since sailed.

Change looks okay - could you look at what happened to the node 0.8 tests in travis?

ashb avatar Jul 29 '14 19:07 ashb

Looks like a random npm failure to me? I didn't change any deps.

eviltrout avatar Jul 29 '14 19:07 eviltrout

Hmmmm its seemed to have been failing for about a month https://travis-ci.org/evilstreak/markdown-js/pull_requests

Bet its some annoyance in a dep that no longer supports node.js 0.8.... Bah.

So we either need to pin grunt (at a guess) to an older version, or drop support for 0.10... thoughts either way?

ashb avatar Jul 30 '14 15:07 ashb

We only use it in browsers so I have no insight into node versions. But 0.8 is quite old isn't it?

eviltrout avatar Jul 30 '14 15:07 eviltrout