markdown-js
markdown-js copied to clipboard
FIX: Error when linking to absolute URLs with absolute links to images
Matching URLs with regular expressions is tough! However, this approach fixes issues when linking to absolute URLs with absolute image URLs inside them.
At times I wish I hadn't built this around regexps :( That :ship: has long since sailed.
Change looks okay - could you look at what happened to the node 0.8 tests in travis?
Looks like a random npm failure to me? I didn't change any deps.
Hmmmm its seemed to have been failing for about a month https://travis-ci.org/evilstreak/markdown-js/pull_requests
Bet its some annoyance in a dep that no longer supports node.js 0.8.... Bah.
So we either need to pin grunt (at a guess) to an older version, or drop support for 0.10... thoughts either way?
We only use it in browsers so I have no insight into node versions. But 0.8 is quite old isn't it?