markdown-js icon indicating copy to clipboard operation
markdown-js copied to clipboard

Updates grunt-node-tap so we have nicer output when feature tests fail

Open eviltrout opened this issue 10 years ago • 10 comments

eviltrout avatar Feb 20 '14 16:02 eviltrout

I think this version of grunt-node-tap caused this issue: https://github.com/evilstreak/markdown-js/issues/174

evilstreak avatar Feb 20 '14 16:02 evilstreak

That error seemed about 1.4.5, this one is 1.5.2; locally I can run the default grunt task and everything works (with nicer output!). Maybe give it a shot locally and let me know if it's a problem?

eviltrout avatar Feb 20 '14 17:02 eviltrout

This works for me, but then pinning at version 0.1.48 which seemed to be the problem previously doesn't fail for me anymore

@jherdman Can you try this branch and let us know if npm test works for you with this?

ashb avatar Feb 20 '14 19:02 ashb

npm test works fine, but grunt does not.

jherdman avatar Feb 20 '14 19:02 jherdman

What errors are you getting in grunt? Grunt works totally fine for me with this version.

On Thu, Feb 20, 2014 at 2:33 PM, James Herdman [email protected]:

npm test works fine, but grunt does not.

Reply to this email directly or view it on GitHubhttps://github.com/evilstreak/markdown-js/pull/179#issuecomment-35659891 .

eviltrout avatar Feb 20 '14 19:02 eviltrout

Fatal error: spawn ENOENT (stack trace is linked)

jherdman avatar Feb 20 '14 19:02 jherdman

I see the same:

% ./node_modules/.bin/grunt all
Running "node_tap:default_options" (node_tap) task
Fatal error: spawn ENOENT

Interestingly:

% PATH=./node_modules/.bin/:$PATH ./node_modules/.bin/grunt
Running "node_tap:default_options" (node_tap) task
Stats: ./test/features.t.js: 196/196
Stats: ./test/html_renderer.t.js: 2/2
Stats: ./test/interface.t.js: 3/3
Stats: ./test/regressions.t.js: 83/83
...

That works. What on earth is grunt-node-tap doing?

ashb avatar Feb 20 '14 19:02 ashb

I have raised an issue with grunt-node-tap - lets see if the author of it has any insights.

ashb avatar Feb 20 '14 19:02 ashb

That's so strange. I just confirmed again that both npm test and grunt all work correctly. It must be some kind of platform issue.

I'm on node v0.10.24

eviltrout avatar Feb 20 '14 20:02 eviltrout

I'm on Node v0.10.26 on OS X if that helps.

jherdman avatar Feb 20 '14 20:02 jherdman