opensnitch icon indicating copy to clipboard operation
opensnitch copied to clipboard

[Feature Request] Buttons on Popup/Notifications

Open GreenLunar opened this issue 3 years ago • 10 comments

Hello, I'm a happy ArchLinux user of OpenSnitch under Xfce desktop, and I want to ask for a new feature. Following issue #476, I'd like to suggest to have an option to enable notification using a notification balloon.

The notification balloon would have 3 three buttons "Deny" "Allow" "Expert" "Expert" button (or whatever name you have in mind) will open the popup dialog which we currently have.

Reason: Intrusiveness While Notification Balloon will be on the top layer of the display, just as the current popup dialog, it will not be intrusive in the sense that it will not cause a fault of a current user's action.

Example: Intrusiveness User is in the middle of adding tags to a bookmark in a web browser, and the popup dialog of OpenSnitch just caused it to be closed.

GreenLunar avatar Aug 17 '21 16:08 GreenLunar

Hi @GreenLunar ,

I like the idea of accepting/denying a connection from a notification, mainly because on some systems there's no systray area, and besides something is changing on this matter https://wiki.debian.org/Ayatana/IndicatorsTransition, https://lists.debian.org/debian-devel/2018/03/msg00506.html

However I think that it should be configurable, users should choose what kind of pop-ups to display: normal (current pop-ups) or minimal (icons on the notification). We already talked about making the pop-ups smaller here #424 and I even prototyped a simpler pop-up, but I think this approach is better.

gustavo-iniguez-goya avatar Aug 17 '21 20:08 gustavo-iniguez-goya

Yes, making it configurable (optional) is a good idea. P.S. The current popup is great.

GreenLunar avatar Aug 17 '21 21:08 GreenLunar

Partially done. On GTK based DEs works from Ubuntu >= 16. On KDE (and others probably) I need to figure out how to start dbus mainloop or attach to the existing dbus session in order to show buttons on the desktop notifications. But it's doable, i.e.: python3-notify2 exists on all major distros since at least ubuntu 16.

Probably I'll add dekstop notifications using libnotify first, to replace systray balloon messages, and then study how to show buttons on notifications in all DEs.

gustavo-iniguez-goya avatar Jan 05 '22 20:01 gustavo-iniguez-goya

This is how it'll look like (with proper formatting): image

gustavo-iniguez-goya avatar Jan 07 '22 21:01 gustavo-iniguez-goya

Awesome!

What about a "Details" or "More Info" button? --- WAIT! By all means, the suggested button is good and I'd love to use it just as it is right not

So... What about a "Details" or "More Info" button?

  • Assuming the default action is directed by default on executable.
  • However, user wants to entirely block the given IP that is displayed on the notification.
  • User clicks on "Details" button, and then does the complex action on the popup which we currently have.

GreenLunar avatar Jan 08 '22 18:01 GreenLunar

What about a "Details" or "More Info" button?

Could be added, but these pop-ups don't offer many options. Out of the box, you can only display text and buttons, so no comboboxes, no checkboxes, no lists, etc.

The "More info" could display all the fields of the connection, and there could be another button to open the GUI.

gustavo-iniguez-goya avatar Jan 10 '22 01:01 gustavo-iniguez-goya

Of course not. The "More Info" button will open the popup dialog that we currently have now

GreenLunar avatar Jan 10 '22 10:01 GreenLunar

This is how it'll look like (with proper formatting): image

I don't have buttons. I've tested with xfce4 and dunst.

GreenLunar avatar Jan 26 '22 02:01 GreenLunar

Yeah, I haven't added it for this release, only system notifications without buttons. I need to figure out how to show the buttons in all DEs.

gustavo-iniguez-goya avatar Jan 26 '22 10:01 gustavo-iniguez-goya

Buttons are the most crucial part. Either way, whether you will add it or not, users of other notification software who won't have button, would still, not have buttons. I suggest to add button, and add note, "Support GNOME, KDE, DE, DE, DE)".

GreenLunar avatar Jan 26 '22 10:01 GreenLunar