librestd icon indicating copy to clipboard operation
librestd copied to clipboard

Fixes arg writing to incorrect scope; statuses now work.

Open amovitz opened this issue 6 years ago • 3 comments

By default, all pages responded with 200. This patch fixes the problem with statuses always responding with 200, regardless of the status set in the program.

amovitz avatar Feb 06 '18 23:02 amovitz

Your PR did not change or fix anything, you just renamed a variable.

evilsocket avatar Feb 07 '18 11:02 evilsocket

The variable change is the fix. With the current state of the code, compile it with an example that should send a 200 on one route and a 400 on another. Both routes will always return a 200. Your code is compiling with a variable scope that sets itself. Example: int i void foo(int i) { i = i; //i (the externale variable) is never set. //This sets the i inside of the function scope. }

amovitz avatar Feb 07 '18 18:02 amovitz

will try to reproduce and update you

evilsocket avatar Feb 07 '18 18:02 evilsocket