add-custom-search-engine icon indicating copy to clipboard operation
add-custom-search-engine copied to clipboard

getting Name and Icon by Search URL doesn't work

Open 532910 opened this issue 6 years ago • 1 comments

https://github.com/soufianesakhi/firefox-search-engines-helper Entering https://search.f-droid.org/?q=%s into Search URL will fill Name with search.f-droid.org and Icon with https://www.google.com/s2/favicons?domain=search.f-droid.org

Add custom search engine will not set Name with "Please fill out this name" error. Will fill wrong Icon URL: https://search.f-droid.org/favicon.ico

532910 avatar Feb 01 '19 12:02 532910

https://github.com/soufianesakhi/firefox-search-engines-helper Entering https://search.f-droid.org/?q=%s into Search URL will fill Name with search.f-droid.org and Icon with https://www.google.com/s2/favicons?domain=search.f-droid.org

Add custom search engine will not set Name with "Please fill out this name" error.

I am not convinced yet that auto-filling the name is useful enough.

Will fill wrong Icon URL: https://search.f-droid.org/favicon.ico

Yeah, that kind of sucks. I don't have a good idea on how to fix this without using the Google service like "Search engine helper", or actually fetching the search URL. Auto-filling the icon is more of a best effort kind of thing. I am almost tempted to remove it, but it does work for a lot of websites.

evilpie avatar Feb 01 '19 12:02 evilpie