figma-polychrom icon indicating copy to clipboard operation
figma-polychrom copied to clipboard

Don’t inline fonts/images manually

Open ai opened this issue 2 years ago • 0 comments

Right now we manually put font in data:uri format https://github.com/mikhin/vite-figma/blob/main/src/ui/style.css#L15

But it is not really maintainable. You can’t open font/image file in system viewer. You can’t replace font just by replacing the file.

Vite can’t inline font by it own. We should keep fonts/images as a regular files and inline them by built tools.

Also, inline is a little bad practice. Font files are big. And base64 decoding and CSS parser is not free. Maybe we should move to separated file and preload tag in HTML.

ai avatar Aug 16 '23 16:08 ai