evidently icon indicating copy to clipboard operation
evidently copied to clipboard

added dash to docker compose to README.md and run_example.py script

Open jeff-ridgeway opened this issue 3 years ago • 1 comments

Submitting a pull request to add a dash to the README.md under the grafana integration examples as well as the run_example.py. There is a dash that is needed between docker and compose for docker-compose. Not having the dash for docker compose makes it so that the run_example.py errors out before building out the grafana and Prometheus dashboard.

jeff-ridgeway avatar Jun 02 '22 01:06 jeff-ridgeway

Hello, in Docker docs two ways for running Docker compose are mentioned - via a separate docker-compose as an old-way and a new command docker compose https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command

We choose to use a new way, a separate command in docker

May be you can describe reasons for the replacement it to docker-compose?

Tapot avatar Jul 26 '22 08:07 Tapot

Hi @jeff-ridgeway , Thank you for bringing this up. We decided to keep using compose V2 , which is described here: https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command If you believe it is wrong decision and we need to reconsider it, please feel free to comment on that and reopen this pull request.

emeli-dral avatar Sep 20 '22 07:09 emeli-dral