evidently icon indicating copy to clipboard operation
evidently copied to clipboard

Feat/add contains link descriptor

Open Sifr-un opened this issue 1 year ago • 3 comments

Implementing "contains link" descriptor. Resolves #1313

Sifr-un avatar Oct 04 '24 22:10 Sifr-un

Hi @Rayryu, Apologies for the delay in reviewing your PR. Thank you for your hard work—the implementation looks great! Could you please add the new descriptor to the list of descriptors under the TextEvals heading on the documentation page? Once that’s done, we’ll be ready to proceed with the merge.

Thanks again!

emeli-dral avatar Oct 16 '24 13:10 emeli-dral

Hi @Rayryu, Apologies for the delay in reviewing your PR. Thank you for your hard work—the implementation looks great! Could you please add the new descriptor to the list of descriptors under the TextEvals heading on the documentation page? Once that’s done, we’ll be ready to proceed with the merge.

Thanks again!

No worries @emeli-dral ! I've added the descriptor under the TextEvals 👌

Sifr-un avatar Oct 16 '24 21:10 Sifr-un

Hi @Rayryu,

Apologies for any confusion regarding the documentation. It looks like you've made changes to the TextEvals preset itself, which is a bit different. If we keep that change, this descriptor will be included in the preset by default, which isn’t quite what we're aiming for.

I was referring to the documentation only! The document is located here: all-metrics.md#text-evals.

Could I kindly ask you to revert the changes to the TextEvals preset itself and just add a line to the documentation?

Feel free to use the other descriptors as a reference! :)

emeli-dral avatar Oct 17 '24 15:10 emeli-dral

Apologies for any confusion regarding the documentation. It looks like you've made changes to the TextEvals preset itself, which is a bit different. If we keep that change, this descriptor will be included in the preset by default, which isn’t quite what we're aiming for.

I was referring to the documentation only! The document is located here: all-metrics.md#text-evals.

Could I kindly ask you to revert the changes to the TextEvals preset itself and just add a line to the documentation?

Feel free to use the other descriptors as a reference! :)

Thanks for the clarification! I see what happened now. I'll revert the changes to the TextEvals preset and update the documentation as you suggested. Appreciate your patience and guidance on this!

Sifr-un avatar Oct 21 '24 20:10 Sifr-un

Hi @Sifr-un ,

Thank you so much for your hard work on this PR! You've done an excellent job, and your efforts are really appreciated. The implementation looks great, and I’m happy to proceed with the merge.

Looking forward to seeing more of your contributions in the future!

emeli-dral avatar Oct 22 '24 14:10 emeli-dral