evidently icon indicating copy to clipboard operation
evidently copied to clipboard

Add is valid sql descriptor

Open Sifr-un opened this issue 1 year ago • 6 comments

Implementing a SQL validator for LLM responses as a new descriptor. Resolves #1321

Sifr-un avatar Oct 04 '24 20:10 Sifr-un

Hi @Rayryu

You have some CI failed jobs, please check it

DimaAmega avatar Oct 07 '24 16:10 DimaAmega

DimaAmega

I've pushed a typo fix.

Sifr-un avatar Oct 07 '24 19:10 Sifr-un

I see that the minimal requirements CI step has failed. I've now added sqlvalidator to the requirements file 👌

Sifr-un avatar Oct 08 '24 18:10 Sifr-un

Hi! To fix mypy you need to add ignore block to setup.cfg in repo root. You can check out mypy section for examples

mike0sv avatar Oct 14 '24 18:10 mike0sv

Hi! To fix mypy you need to add ignore block to setup.cfg in repo root. You can check out mypy section for examples

Thank you @mike0sv for chiming in. I've added a sqlvalidator block in setup.cfg.

Sifr-un avatar Oct 14 '24 18:10 Sifr-un

Hi @Rayryu,

It looks like we're almost there!

Could you please add the new descriptor to the list of descriptors under the TextEvals section on the documentation page? The file that needs to be updated is located here: all-metrics.md#text-evals.

Once that’s done, we’ll be all set to proceed with the merge!

emeli-dral avatar Oct 17 '24 17:10 emeli-dral

Hi @Sifr-un , do you need some help with adding IsValidSQL to the list of descriptors under the TextEvals section all-metrics.md#text-evals?

emeli-dral avatar Oct 28 '24 11:10 emeli-dral

@emeli-dral, how can I help to speed this up? Merge the changes from this branch and prepare new PR?

vectorvp avatar Nov 22 '24 12:11 vectorvp