evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Sparkline rendering bug

Open mcrascal opened this issue 2 years ago • 4 comments

Bug Description Sparkline in the dev workspace is showing a flat line.

mcrascal avatar Mar 20 '23 20:03 mcrascal

Additional Context:

In BigValue.svelte; a sparkline is available as a prop. When provided a tiny-linked-chart is rendered. On the example page, it appears that this is still working, but the scale of the Y axis may be getting thrown off. In the image below; the type="line" was removed, to render as a bar chart; and there is some data visible.

image

ItsMeBrianD avatar Mar 20 '23 20:03 ItsMeBrianD

I think there's good rationale to replace svelte-tiny-linked-charts with eCharts in the BigValue:

Demo repl

archiewood avatar Nov 20 '23 20:11 archiewood

I’m replacing the svelte-tiny-linked-charts dependency with our own echarts-based sparklines.

I’ve got a setting for interactive - if false, it just renders an SVG. If true it gives you tooltips. Not sure what the default should be, but I’m thinking we’ll need the static version when we eventually put sparklines into tables so as not to overwhelm the page with echarts instances.

Having some fun messing around with interactivity - this accepts a valueFmt and dateFmt: CleanShot 2024-02-25 at 13 18 03

What’s also cool is these can be used inline outside of BigValue: CleanShot 2024-02-25 at 13 21 09@2x

hughess avatar Feb 25 '24 18:02 hughess

Since these are all time series, we could also connect the sparklines when set to interactive:

CleanShot 2024-02-25 at 13 30 17

hughess avatar Feb 25 '24 18:02 hughess