evidence
evidence copied to clipboard
evidence-dev
added scroll to prop sections of docs
Description
Checklist
- ~~For UI or styling changes, I have added a screenshot or gif showing before & after~~
- ~~I have added a changeset~~
- ~~I have added to the docs where applicable~~
- ~~I have added to the VS Code extension where applicable~~
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 29, 2024 8:17pm |
| next-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 29, 2024 8:17pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
🦋 Changeset detected
Latest commit: 210415e2ecc872fdc28ab85f0d718d977ddf94e9
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @evidence-dev/components | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for evidence-development-workspace ready!
| Name | Link |
|---|---|
| Latest commit | 210415e2ecc872fdc28ab85f0d718d977ddf94e9 |
| Latest deploy log | https://app.netlify.com/sites/evidence-development-workspace/deploys/66d0d594f6ad9a0008dc6554 |
| Deploy Preview | https://deploy-preview-2324--evidence-development-workspace.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for evidence-test-env ready!
| Name | Link |
|---|---|
| Latest commit | 210415e2ecc872fdc28ab85f0d718d977ddf94e9 |
| Latest deploy log | https://app.netlify.com/sites/evidence-test-env/deploys/66d0d59480a0690008dc90d3 |
| Deploy Preview | https://deploy-preview-2324--evidence-test-env.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for next-docs-evidence ready!
| Name | Link |
|---|---|
| Latest commit | 210415e2ecc872fdc28ab85f0d718d977ddf94e9 |
| Latest deploy log | https://app.netlify.com/sites/next-docs-evidence/deploys/66d0d59495ad960008f45e13 |
| Deploy Preview | https://deploy-preview-2324--next-docs-evidence.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Added <a href="#props-{name}" to doc's prop section.
Click on Value, scrolls you to Value in prop section, as well as updates the url (/components/big-value/#props-value)
https://www.loom.com/share/6d859aa798c54eb2921146b1ad2900f2
Entering that URL in a new tab will scroll to the specified section once the page opens. However, an existing issue was discovered: In the example video, the Big Value component loads after the initial scroll. This change affects the height of the page, causing the viewport's scroll position to shift, so the intended scroll position is no longer accurate.
Test example for Current Docs site & Local branch with prop scroll https://www.loom.com/share/233bc359290f4d61a533576265d8ffcb
Changed URL event listener in onMount, to fix build errors I was experiencing.
Concern: Is it an issue that all PropListing Components have an event listener for the hash changes?
Event listener logic handled in context='module', created and removed once per page