evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Added stories for value BigValue array handling

Open kwongz opened this issue 1 year ago • 7 comments

Description

Checklist

  • [x] For UI or styling changes, I have added a screenshot or gif showing before & after
  • [ ] I have added a changeset
  • ~~I have added to the docs where applicable~~
  • ~~I have added to the VS Code extension where applicable~~

After looking into the code, this has already been fixed. Big Value and Value both have array checking and wrapping

Big Value: image

Value: image

Stories added with each block example that was breaking

Big Value:

`{#each data2 as my_row}
	<BigValue {...args} data={my_row} value="total_y" />
{/each}`

image

Value: {#each forEachData as my_row} {my_row.series} <div> <p>Y Total:</p> <Value data={my_row} value="total_y" color="#00FF00" /> </div> <div style="margin-bottom: 1em;"> <p>X Total:</p> <Value data={my_row} value="total_x" color="#674EA7" /> </div> {/each}

image

kwongz avatar Aug 12 '24 18:08 kwongz

⚠️ No Changeset found

Latest commit: a2e41bd09dc48b1f7356296a4a0731c50730f674

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 12 '24 18:08 changeset-bot[bot]

uncertain if this requires changeset

kwongz avatar Aug 12 '24 18:08 kwongz

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit a2e41bd09dc48b1f7356296a4a0731c50730f674
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/66d0e3beb0a5d10008586ba0
Deploy Preview https://deploy-preview-2320--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 18:08 netlify[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:17pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:17pm

vercel[bot] avatar Aug 12 '24 18:08 vercel[bot]

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit a2e41bd09dc48b1f7356296a4a0731c50730f674
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/66d0e3beae9c280008d1bfb7
Deploy Preview https://deploy-preview-2320--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 18:08 netlify[bot]

Deploy Preview for evidence-test-env ready!

Name Link
Latest commit a2e41bd09dc48b1f7356296a4a0731c50730f674
Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/66d0e3bea0b95d0008df3ef7
Deploy Preview https://deploy-preview-2320--evidence-test-env.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 12 '24 18:08 netlify[bot]

fix #1677

kwongz avatar Aug 12 '24 19:08 kwongz

Resolved conflict,

I am noticing some odd behavior in the storybook with Value + BigValue and other components.

Sometimes the component mounts nothing, empty data, or the expected data

image

image

It used to be that we could click the refresh/remount button and everything would be fine, but now we are consistently getting no data, or nothing with Value and Big Value

kwongz avatar Aug 29 '24 21:08 kwongz

Sometimes the component mounts nothing, empty data, or the expected data

Should address this before merging. This may have to do with data loading?

ItsMeBrianD avatar Sep 04 '24 16:09 ItsMeBrianD

sounds good, will look into it

kwongz avatar Sep 04 '24 19:09 kwongz

Sometimes the component mounts nothing, empty data, or the expected data

Should address this before merging. This may have to do with data loading?

Since this is just stories added here, I'm going to merge now and we can address the loading issue separately as it likely affects more than just these stories

zachstence avatar Sep 13 '24 16:09 zachstence