evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Added link prop to Value Component

Open kwongz opened this issue 1 year ago • 9 comments

Description

Checklist

  • [x] For UI or styling changes, I have added a screenshot or gif showing before & after
  • [x] I have added a changeset
  • [x] I have added to the docs where applicable

Added Link Prop to Value with Blue hover state

image

Copied the structure of the Link Prop Description from the Link Button

image

If this styling is ideal, we can normalize the blue hover state, and "link" (e.g Big Link uses "href") to the other components I've come across using links; Big Link, Button Link, Big Value

NOTE: I think as the linking in charts/graphs becomes more specific (i.e x-axis title link, line chart link), we define those prop descriptions accordingly.

kwongz avatar Jun 25 '24 18:06 kwongz

🦋 Changeset detected

Latest commit: c5870d31152b251178e076e9a0df304a165d7227

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
my-evidence-project Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 25 '24 18:06 changeset-bot[bot]

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit c5870d31152b251178e076e9a0df304a165d7227
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/667b69f3388bc00008f65a16
Deploy Preview https://deploy-preview-2155--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 18:06 netlify[bot]

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit c5870d31152b251178e076e9a0df304a165d7227
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/667b69f30b1d7c0008dd351b
Deploy Preview https://deploy-preview-2155--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 18:06 netlify[bot]

Deploy Preview for evidence-test-env ready!

Name Link
Latest commit c5870d31152b251178e076e9a0df304a165d7227
Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/667b69f37ffd340008b8ddd2
Deploy Preview https://deploy-preview-2155--evidence-test-env.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 18:06 netlify[bot]

I like this implementation. Can we merge all these PRs into a feature branch eg chart-drill-through so we can review them as a whole at the end

archiewood avatar Jun 25 '24 19:06 archiewood

@archiewood Sounds good!

Would you still like individual PRs for each component before merging them into the Feature?

kwongz avatar Jun 26 '24 13:06 kwongz

i think that will keep them organised yep

archiewood avatar Jun 26 '24 16:06 archiewood

sorry to be clearer, you dont need individual PRs for BarChart, LineChart, AreaChart etc, as they basically all use the same code.

but it might make sense to separate those ones from this one, for example

archiewood avatar Jun 27 '24 14:06 archiewood

That makes sense, as I am working on BarChart I can get a better understanding of what components can be grouped.

Thanks for the clarification!

kwongz avatar Jun 27 '24 14:06 kwongz