evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Dropdown search does not work

Open fboerman opened this issue 9 months ago • 2 comments

Steps To Reproduce

create a dropdown with some options from a sql query. observe that search does not work. this is with latest version (34)

Environment

  • Node version (node -v): v20.12.2
  • npm version (npm -v): 10.5.2
  • OS: archlinux
  • Browser: firefox (but unrelated)
  • Database: csv (but unrelated)

Expected Behavior

search should filter the options

Actual Behaviour

it does either nothing or removes all options

Workarounds

none found so far, just straight up broken

fboerman avatar May 04 '24 13:05 fboerman

This is likely fixed by #1980; I haven't been able to get a repro, if there is one available would love to dig into it

ItsMeBrianD avatar May 07 '24 02:05 ItsMeBrianD

Dropdown search "works" at 34.0.1, but there is definitely room for improvement.

  1. Search has no effect on manually added DropdownOptions
  2. Keeping selected items at the top of the list while searching is counterintuitive, especially in a multi-select where you might have many items sitting at the top
  3. The actual search function seems far too permissive, I think we need to more aggressively eliminate options. For example, the search Blargghhh should not yield a list of options with Larry Gaish at the top, it should yield no options.

mcrascal avatar May 15 '24 19:05 mcrascal

This was resolved by #2096

ItsMeBrianD avatar Jun 18 '24 14:06 ItsMeBrianD