evidence
evidence copied to clipboard
Semi-fix SQLConsole bug
Description
Fixes SQLConsole crashing page on navigation, but only fixes the symptom of some greater bug that has something to do with on-page queries + transitions?
To reproduce the bigger bug:
- Clone & run https://github.com/csjh/sqlconsole-transition-repro
- Click on link to test
- Click on link back to home
- Witness error in dev console
Suspect it might be a Svelte bug, since I can't figure out anything we would be doing that would make Svelte complain
Checklist
- [x] I have added a changeset
🦋 Changeset detected
Latest commit: 37cbbc43e016733cd3a9cf3ec89f06f4f833c343
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
| Name | Type |
|---|---|
| @evidence-dev/core-components | Patch |
| @evidence-dev/evidence | Patch |
| @evidence-dev/components | Patch |
| evidence-test-environment | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| docs | ✅ Ready (Inspect) | Visit Preview | Feb 26, 2024 10:17pm |
Deploy Preview for evidence-development-workspace ready!
| Name | Link |
|---|---|
| Latest commit | 37cbbc43e016733cd3a9cf3ec89f06f4f833c343 |
| Latest deploy log | https://app.netlify.com/sites/evidence-development-workspace/deploys/65dd0ddd42236000084c0563 |
| Deploy Preview | https://deploy-preview-1640--evidence-development-workspace.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
What is the status of this PR? Can it be merged?
@ItsMeBrianD a weird svelte bug I'm trying to repro
@archiewood I'll merge as a temp fix, can revert later when there's a full fix on our or svelte side
nvm it's fixed in svelte 5