evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Semi-fix SQLConsole bug

Open csjh opened this issue 1 year ago • 3 comments

Description

Fixes SQLConsole crashing page on navigation, but only fixes the symptom of some greater bug that has something to do with on-page queries + transitions?

To reproduce the bigger bug:

  1. Clone & run https://github.com/csjh/sqlconsole-transition-repro
  2. Click on link to test
  3. Click on link back to home
  4. Witness error in dev console

Suspect it might be a Svelte bug, since I can't figure out anything we would be doing that would make Svelte complain

Checklist

csjh avatar Feb 26 '24 22:02 csjh

🦋 Changeset detected

Latest commit: 37cbbc43e016733cd3a9cf3ec89f06f4f833c343

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 26 '24 22:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 26, 2024 10:17pm

vercel[bot] avatar Feb 26 '24 22:02 vercel[bot]

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 37cbbc43e016733cd3a9cf3ec89f06f4f833c343
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/65dd0ddd42236000084c0563
Deploy Preview https://deploy-preview-1640--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 26 '24 22:02 netlify[bot]

What is the status of this PR? Can it be merged?

archiewood avatar Feb 28 '24 16:02 archiewood

@ItsMeBrianD a weird svelte bug I'm trying to repro

@archiewood I'll merge as a temp fix, can revert later when there's a full fix on our or svelte side

csjh avatar Feb 28 '24 19:02 csjh

nvm it's fixed in svelte 5

csjh avatar Feb 28 '24 19:02 csjh