evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Add Heatmap to legacy

Open hughess opened this issue 2 years ago • 7 comments

Checklist

  • [ ] For UI or styling changes, I have added a screenshot or gif showing before & after
  • [ ] I have added a changeset

hughess avatar Feb 14 '24 05:02 hughess

⚠️ No Changeset found

Latest commit: c6d3f2211610343494237acbab7a7e0b00a23cc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 14 '24 05:02 changeset-bot[bot]

Deploy Preview for evidence-development-workspace failed.

Name Link
Latest commit c6d3f2211610343494237acbab7a7e0b00a23cc5
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/65cc4fa92df37e000892cdac

netlify[bot] avatar Feb 14 '24 05:02 netlify[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 5:29am

vercel[bot] avatar Feb 14 '24 05:02 vercel[bot]

Should this be pointing to legacy branch instead of next?

Based on line change count this also may have been branched off of next rather than legacy, so we'll need to cherrypick and/or move the changes over to a branch based on legacy if that's the case

ItsMeBrianD avatar Feb 22 '24 15:02 ItsMeBrianD

@ItsMeBrianD presumably this needs a changeset too? Or do we want to manually version legacy changes?

archiewood avatar Feb 22 '24 15:02 archiewood

Dev workspace is going to fail because USQL adds build:sources step which does not exist in legacy

archiewood avatar Feb 22 '24 15:02 archiewood

Or do we want to manually version legacy changes?

We can try changesets but we might want to fall back to manual versioning to ensure we don't conflict

ItsMeBrianD avatar Feb 22 '24 15:02 ItsMeBrianD

can we close this? @hughess - I think we do not need to release this on legacy?

archiewood avatar Mar 08 '24 19:03 archiewood