evidence icon indicating copy to clipboard operation
evidence copied to clipboard

Date Range, Multi Select, Input Improvements

Open archiewood opened this issue 2 years ago • 4 comments

Description

See #1477

Outstanding

  • keyboard a11y (Dropdown)
  • handling breaking nature of syntax change (major bump?) (Dropdown)
  • still see 1970 sometimes (Date Range)
  • defaultValue no longer works (Dropdown)
  • inconsistent indentation of dropdown labels if you have long names in Dropdown Options (Dropdown)
  • there is no title label that can be seen above dropdown if single select (Dropdown)
  • remove the CSV I added

Nits:

  • list height if <5 options (Dropdown)
  • search if <5 options is odd (Dropdown)

Checklist

  • [ ] For UI or styling changes, I have added a screenshot or gif showing before & after
  • [ ] I have added a changeset

archiewood avatar Feb 07 '24 19:02 archiewood

🦋 Changeset detected

Latest commit: 0785c08271bcfd26633ddf7b64b540e14e95a9ee

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 07 '24 19:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 11:17pm

vercel[bot] avatar Feb 07 '24 19:02 vercel[bot]

Deploy Preview for evidence-development-workspace failed.

Name Link
Latest commit 0785c08271bcfd26633ddf7b64b540e14e95a9ee
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/65e6563ec4451a0008c00e58

netlify[bot] avatar Feb 08 '24 18:02 netlify[bot]

  1. The Single Select seems to have some aligment issues - I think the checkmark svg is a different size dependant on the text length

CleanShot 2024-02-08 at 13 18 20@2x

  1. I think we still need the label for the title above the dropdown if it is single select

CleanShot 2024-02-08 at 13 22 38

Otherwise there's no way to identify what the field I'm changing is for the end user e.g. country

archiewood avatar Feb 08 '24 18:02 archiewood

Can this be closed now? @mcrascal

ItsMeBrianD avatar Mar 06 '24 03:03 ItsMeBrianD