evidence icon indicating copy to clipboard operation
evidence copied to clipboard

WIP: Flowchart Component

Open ItsMeBrianD opened this issue 2 years ago • 7 comments

Description

Checklist

  • [ ] For UI or styling changes, I have added a screenshot or gif showing before & after
  • [ ] I have added a changeset

Resolves #1397

ItsMeBrianD avatar Jan 08 '24 22:01 ItsMeBrianD

🦋 Changeset detected

Latest commit: 0e428ea432cd470fede203cdc1d78713819ad56b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 08 '24 22:01 changeset-bot[bot]

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 0e428ea432cd470fede203cdc1d78713819ad56b
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/65e64b105a4b5f0008d2ff68
Deploy Preview https://deploy-preview-1472--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 08 '24 22:01 netlify[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 10:29pm

vercel[bot] avatar Jan 08 '24 22:01 vercel[bot]

Resolves #1397

ItsMeBrianD avatar Feb 01 '24 19:02 ItsMeBrianD

@ItsMeBrianD reminder: this needs to go on legacy

mcrascal avatar Feb 05 '24 22:02 mcrascal

Test w/ multiple flow charts on the same page

mcrascal avatar Feb 05 '24 22:02 mcrascal

Just had follow up from the customer on this. What is the status of this PR?

archiewood avatar Feb 16 '24 15:02 archiewood

I'm having some problems getting this to work consistently. Here's what I've run into so far:

  • Flash of chart config text before the diagram loads
    • I added a store and a loading state so this is mostly solved, but there is still occasionally a split second where the text appears on the page
    • I attempted to add a callback to set the loaded store to true, but that causes the diagram to stop drawing before it's finished
  • Overlapping charts - seems like it's overwriting other instances
    • I've set a unique ID on each div and confirmed the updateChart() function only works on each separate div, but somehow mermaid still writes 2 diagrams into the same div

hughess avatar Mar 20 '24 18:03 hughess