Cosmos icon indicating copy to clipboard operation
Cosmos copied to clipboard

Allow adding of subviews

Open UnknownJoe796 opened this issue 2 years ago • 3 comments

This fixes an issue where adding a subview to a CosmosView would cause a crash.

UnknownJoe796 avatar Nov 30 '21 19:11 UnknownJoe796

Thanks for the PR. Before fixing the issue, I would like to reproduce it first. How do I reproduce the bug?

evgenyneu avatar Dec 03 '21 21:12 evgenyneu

Oh, sorry I missed your comment in my notifications! AFAIK all you have to do is add a subview to a CosmosView and it'll crash. I caused it working with something very similar to LifecycleHooks.
If you need me to create a test for it, I can do that. Thanks!

UnknownJoe796 avatar Dec 14 '21 22:12 UnknownJoe796

Oh I see, adding subviews to Cosmos view is not supported, to make the code simple. Sorry.

evgenyneu avatar Dec 17 '21 03:12 evgenyneu