telegram-react icon indicating copy to clipboard operation
telegram-react copied to clipboard

ThemePicker in mobile view - Uncaught RangeError: Maximum call stack size exceeded

Open web-telegram opened this issue 4 years ago • 1 comments

ThemePicker

https://github.com/evgeny-nadymov/telegram-react/blob/47501078af852d0d2262247a79084c3fee5b8736/src/Components/ColumnLeft/Settings/General.js#L99

I think moving the ThemePicker to SidebarPage will solve this problem and make it look better:

<SidebarPage open={openThemePicker} onClose={this.closeThemePicker}>
                <ThemePicker ref={this.themePickerRef} />
 </SidebarPage>

web-telegram avatar Dec 28 '20 13:12 web-telegram

I agree, it should be better to wrap ThemePicker with SidebarPage component. RangeError has been fixed at groupcalls branch https://github.com/evgeny-nadymov/telegram-react/blob/47501078af852d0d2262247a79084c3fee5b8736/src/Components/ColumnLeft/ThemePicker.js#L118

evgeny-nadymov avatar Dec 29 '20 01:12 evgeny-nadymov