Evgeni Golov

Results 620 comments of Evgeni Golov

should the whole "wait for tasks before backup" part be split out in an own commit/PR?

split the big patch into four logical commits, enjoy!

hm, need to adjust tests. later.

> I'm not sure the systemd check is relevant. Debian also starts it via systemd, but somehow does read `data_directory` via `postgresql.conf`. Well, this is where *we* set PGDATA explicitly....

I can reproduce the issue, it comes from a recent security fix in Rack (https://github.com/rack/rack/commit/79ab0b9794a529f26a9a5eba10077f5ee6a097ce) What I do not understand is: why our request is so big, we're uploading 2MB...

Ahahaha, we're encoding the upload as `application/x-www-form-urlencoded` and not as `multipart/form-data`, which blows up the size. Fix incoming.

FWIW, I've released 5.4.0 with the workaround (see https://github.com/theforeman/foreman-ansible-modules/pull/1872), the real fix needs more work on the Katello side, sadly.

@rh-manash redhat.satellite 5.4.0 is on AH since yesterday, so you can update to that

Sure is, even with a merged patch ;) https://github.com/Katello/katello/pull/11408