Evgeni Golov comments

Results 620 comments of


                                            Evgeni Golov

correctly encode content uploads as multipart/form-data

interestingly, the uploaded data is corrupt :see_no_evil:

correctly encode content uploads as multipart/form-data

https://projects.theforeman.org/issues/38482 - https://github.com/Katello/katello/pull/11408

correctly encode content uploads as multipart/form-data

As this seems to require more work, let's apply a workaround for now: https://github.com/theforeman/foreman-ansible-modules/pull/1872

add backend serveraliases to debian vhosts

Need? No. Would I like to have the same layout there? Yes :)

Add 'report_diff' key in result data in case of available diff data

Why would you alter the data here instead of passing before/after verbatim to Foreman and let the UI render it in whichever way it likes?

Add 'report_diff' key in result data in case of available diff data

The Ansible callback here is just "the messenger", we (well, you ;) ) can adapt to whatever foreman/foreman_ansible (I don't recall which one carries the report parsing these days) expects....

Add 'report_diff' key in result data in case of available diff data

I have merged the test cleanup PRs, thanks for that! The diff here looks quite reasonable, but I guess we should first get movement on the receiving end (foreman_ansible) for...

Add 'report_diff' key in result data in case of available diff data

I think the diff looks fine, but I'd prefer https://github.com/theforeman/smart_proxy_ansible/pull/98 and https://github.com/theforeman/foreman_ansible/pull/749 being merged first.

create ssl cert per vhost, not one monster

finally updated!

Galaxy importer warnings/errors - version 5.0.0

all but the ansible-lint ones have been fixed now