libspeedhack icon indicating copy to clipboard operation
libspeedhack copied to clipboard
verified publisher icon evg-zhabotinsky

Pls merge

Open Twig6943 opened this issue 6 months ago • 3 comments

  • Adds -lm #14
  • Makes it use .config for files (this is required for it to work without root in some cases)
  • Adds placeholder CONTRIBUTING & actions files

Twig6943 avatar Jun 07 '25 09:06 Twig6943

this is a necropost or something, but rm -f ~/.config/speedhack/speedhack_{pipe,log} should probably be replaced with rm -f ~/.config/{speedhack_pipe,speedhack/speedhack_log} to function as intended

normalUserKarn avatar Jul 08 '25 03:07 normalUserKarn

Sorry for the wait, this PR slipped my attention.

  • What is -lm for? I distinctly remember getting rid of the flag to avoid a potential extra dependency for portable builds. The current "release" binaries only depends on libc.
  • Moving from /tmp to ~ is indeed a good idea for multi-user systems, in case there are stale files from other users, but I think ~/.cache/libspeedhack/ would be a better location, it is the closest per-user equivalent to /tmp.

evg-zhabotinsky avatar Jul 08 '25 04:07 evg-zhabotinsky

just nvm this pr (this thing is kinda useless since it needs to be rewritten

Twig6943 avatar Jul 08 '25 09:07 Twig6943