seat icon indicating copy to clipboard operation
seat copied to clipboard
verified publisher icon eveseat

Killmail Notifications Count As Losses When Victim Is NPC

Open tehraven opened this issue 4 years ago • 0 comments

  • Problem: When a killmail is being notified out, it counts as a "loss" when the victim is in an NPC corp, which matches some of our alts in the system.
  • Expected: It counts as a kill.
  • Logs / Screenshots / Proof:
    • Only one affiliation in the Notification Group (a corporation)
    • Victim is in NPC corp https://zkillboard.com/kill/96929522/
    • image
    • This code matches the victim's corp to any npc character registered in my system: https://github.com/eveseat/notifications/blob/05fdac97fa59133447cc31f34d74816639cc2db9/src/Notifications/Characters/Slack/Killmail.php#L103
  • Version Info:
    • SeAT API Installed: v4.7.0
    • SeAT Console Installed: v4.8.0
    • SeAT Eve API Installed: v4.14.0
    • SeAT Notifications Installed: v4.3.1
    • SeAT Services Installed: v4.2.0
    • SeAT Web Installed: v4.15.0

I would have presented a functioning PR to resolve this, but the eveapi repo doesn't have a "not NPC" query today, and I didn't want to make that PR unless it was agreed to be a good call. (https://github.com/eveseat/eveapi/blob/bc794a570b25e4355efc1091c4a7e276706e0775/src/Models/Corporation/CorporationInfo.php#L165)

tehraven avatar Nov 25 '21 23:11 tehraven