everzakov
everzakov
> Wanna do a PoC Yeah, I will make a PoC. You can check the first version using the pipe in this commit https://github.com/everzakov/runc/commit/bc442cc717f50a75b44073b306cabe5e6aff46c3 . However, this is based on...
> I guess what Alan suggested is a better way Hello! Something like this https://github.com/opencontainers/runc/commit/4cdc0d64123bf2afb652fdf08842895261d0924b ? I have made this as a Container method.
> In fact, runc doesn’t call `cmd.Wait()` directly—it uses `cmd.Process.Wait()` instead to wait for the child process. Actually there are some calls cmd.Wait() - https://github.com/opencontainers/runc/blob/v1.4.0/libcontainer/process_linux.go#L152 and https://github.com/opencontainers/runc/blob/v1.4.0/libcontainer/process_linux.go#L524 . > I...
> A virtual TPM sounds interesting to me. Is there a runtime-spec PR for this already? That will be needed too. > > I haven't had a look at the...
> Therefore this is working as intended I don't think so because the error is returned by cmd.Wait not by cmd.Start. cmd.Start does not return an error.
> A Cmd object can be used for at most one process. See: > > // A Cmd cannot be reused after calling its [Cmd.Start], [Cmd.Run], > // [Cmd.Output], or...
> Since Start already does detect re-use (by returning an error) I Sorry but you are wrong. The second cmd.Start do not return an error. The error is returned by...
> it's a pretty small minority of uses of Start that fail in this way. In runc 1.4 in [startWithCgroupFD](https://github.com/opencontainers/runc/blob/v1.4.0/libcontainer/process_linux.go#L370) function cmd.Start can be called twice (if the first returned...