everydayrails-rspec-2017

everydayrails-rspec-2017 copied to clipboard

In page 185, chapter 11, you use `sign_in` method: However, you use `login_as` method in page 188 and 194: I think they should be `sign_in` too.

JunichiIto

In page 158, chapter 9, you write the code below: ```ruby RSpec.configure.do |config| config.filter_run focus: true config.run_all_when_everything_filtered = true end ``` Since RSpec 3.5, you can write like this: ```ruby...

JunichiIto

In page 140, chapter 8, it shows "using our customer login helper", but I think it should be "using our custom login helper". The sample code should be fixed too:...

JunichiIto

In page 121, chapter 8, the error of `tasks_spec.rb` (`tasks_feature.rb`?) is displayed, but the text does not mention it at all. It might be a confusing result without mentioning it.

JunichiIto

mimemagic 0.3.2 was yanked

6

This is just FYI. `bundle install` for this app will fail because mimemagic 0.3.2 was yanked. https://github.com/everydayrails/everydayrails-rspec-2017/blob/76f8d23cc5516eb1f1cae11139b71f3e48ca1ac9/Gemfile.lock#L135 https://rubygems.org/gems/mimemagic/versions/0.3.2 ``` $ bundle install ... Your bundle is locked to mimemagic (0.3.2),...

JunichiIto

In Chapter 3, "Testing instance methods" section, the sample code ```ruby def name [firstname, lastname].join(' ') end ``` should be ```ruby def name [first_name, last_name].join(' ') end ```

JunichiIto

# 内容 - FactoryBotを使ってテストデータを作成する

k-toriik-torii

Chapter 6: Capybara initial test fails

9

I am completely baffled by this and the fact I cannot find any information about how to do this is downright infuriating. Using the following scenario from pages 95-96: ```...

kkerley

_task.json.jbuilder has invalid arguments for project_task_url

1

A reader of the Japanese edition found that `_task.json.jbuilder` has invalid arguments for `project_task_url`. https://github.com/everydayrails/everydayrails-rspec-2017/blob/90b22535d44ab626b82363335a227c5a1856a039/app/views/tasks/_task.json.jbuilder#L2 It should be: ```ruby json.url project_task_url(task.project, task, format: :json) ``` The current test fails if...

JunichiIto

masataka-creator