evershop icon indicating copy to clipboard operation
evershop copied to clipboard

Fix #334: Fixed overlapping of price text and min-max handles

Open imshubs24 opened this issue 1 year ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

  1. Max price text collides with min price.
  2. Thumbs of slider overlaps.

Issue Number: #334

What is the new behavior?

  1. Fixed the texts of both min and max on left and right respectively to avoid collision.
  2. Increased the range between min and max, so thumbs wont overlap with each other.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

imshubs24 avatar Jan 26 '24 08:01 imshubs24

Hi @slokhande310 ,

I see you turned off some rules in the linting config. Can I suggest to keep the original set of rules and try to fix the code? Let me know if you need a support

Thanks

treoden avatar Jan 30 '24 03:01 treoden

This is the first time I ever came across this error, I googled it and I think if I add aria labels, it might fix the errors.

imshubs24 avatar Jan 30 '24 13:01 imshubs24

Hi @treoden, I fixed the errors and re-enabled the linting rules which I disabled earlier but there's one error that doesn't fix, I tried but I was not able to fix it.

https://github.com/evershopcommerce/evershop/blob/8f3158a0b9b0ebf40376ae1ba0f042787b04eb05/packages/evershop/src/components/common/form/fields/Ckeditor.jsx#L364

Error: A form label must be associated with a control jsx-a11y/label-has-associated-control

imshubs24 avatar Jan 31 '24 11:01 imshubs24