Caleb Everett

Results 56 comments of Caleb Everett

There error is here, `IonTypes` is undefined. We can see IonTypes is imported from Ion.js ``` import { IonTypes, toBase64 } from "../Ion"; import { Lob } from "./Lob"; export...

Okay, I have a minimal reproduction now with a few lines can be imported with node but fail in vitest. ``` // ion-js // ├── dom // │   ├── Blob.js...

I think it's caused by this line https://github.com/vitest-dev/vitest/blob/482b72fc5f02da87498a18e0ed844ecb6bc772ca/packages/runner/src/types/tasks.ts#L148 and it appears to be fixed by changing it to ``` (name: string, fn?: TestFunction, options?: number | TestOptions): void ``` But...

Also missing [AbortSignal.timeout](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/timeout)

I'm not familiar with how sinon fake timers is implemented but when I need to mock AbortController.timeout() I'll use ```typescript timeout(n) { const controller = new AbortController() setTimeout(() => controller.abort(),...

I've written an RFC and pull request implementing option to ignore resolved values in lockfiles that would fix this bug. https://github.com/npm/rfcs/pull/486 https://github.com/npm/cli/pull/4264

If you install dependencies in the package, instead of the workspace root, bundled dependencies will be included ``` $ cd packages/a $ npm install $ npm pack $ tar --list...

Totally acceptable solution to me, tho it does change the schema of the json record, and would change how logs are stored in cloudwatch if POWERTOOLS_DEV=1 was used in lambda....

Similar to what existing one? Why is moduleNameMapper in scope but resolver is not?

I'm not sure why napi-rs generates the code it does, instead of maybe a try/catch, or a loop over candidate files. I can work on a PR if either of...