ever-traduora icon indicating copy to clipboard operation
ever-traduora copied to clipboard

Add automatic translations with google

Open haringsrob opened this issue 3 years ago • 11 comments

Hi,

This is a proposal pr for adding google translate as an automatic translation service.

While the pr needs still a lot of work I wanted to share this draft so we can discuss if it is something good or not for this project.

I have never worked with typescript, I did my best to follow conventions but sorry if I missed out on things.

There are quite some todo's inline that further describe the idea, potential issues and improvements that can be done.

Thank you for this awesome project!

haringsrob avatar Nov 06 '20 18:11 haringsrob

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 06 '20 18:11 CLAassistant

Hey this looks awesome! Thanks for proposing these changes, I will checkout the code in the coming days.

Btw regarding marking the translations as "machine translated", you could use the tagging feature to add some tags automatically to those translations if that's what you're looking for. Should be pretty straightforward.

anthonynsimon avatar Nov 07 '20 19:11 anthonynsimon

Ah that is an interesting take indeed. I will check that out.

haringsrob avatar Nov 08 '20 13:11 haringsrob

This is awesome.. Just what I need for my project. Already created an issue for this #156

arelstone avatar Nov 26 '20 13:11 arelstone

@anthonynsimon what about this PR? :)

fnowacki avatar Feb 23 '21 12:02 fnowacki

@fnowacki I think this feature is great! However, I see many TODO's still open in the changes - would have to wait for those before merging :)

anthonynsimon avatar Feb 24 '21 16:02 anthonynsimon

I personally do not have much time at the moment to focus on this. I think the pr is open for changes :).

haringsrob avatar Feb 24 '21 18:02 haringsrob

@haringsrob thanks for the update, and no worries - I understand :)

anthonynsimon avatar Feb 24 '21 19:02 anthonynsimon

Would be great if we could get someone to finish this. Really looking forward to this feature

arelstone avatar Feb 26 '21 07:02 arelstone

Has this every been implemented?

Alex-Giaquinto avatar Oct 24 '23 20:10 Alex-Giaquinto

@Alex-Giaquinto / @fnowacki afraid it was not implemented. The PR indeed have a lot of TODOs that need to be resolved/improved etc. In addition, there are many more automatic translation options now, e.g. including OpenAI API, etc. I think we will need an approach with "providers" that allow translation services and implement that with some sort of plugin infrastructure, e.g. "Google Translate Plugin", "OpenAI Translate Plugin", etc. So it requires more work...

evereq avatar Oct 25 '23 07:10 evereq