Brian Donovan

Results 80 comments of Brian Donovan

Looking at this now, I think this might just be normal [zsh command substitution](https://zsh.sourceforge.io/Intro/intro_7.html).

I agree with @strand. I think it is much clearer what's public and what's private for the simple reason that I don't have to (at best) scan upwards until I...

I'm running into this too with the default coverage tooling for Jest (istanbul). My workaround so far is to ignore anything that looks like a helper in the first line...

This is how `babel-jest` handles it: https://github.com/facebook/jest/blob/3a8696bcf0e02a5f59080123d1a20e8b6d66d8df/packages/babel-jest/src/index.ts#L52

FWIW, this is what I get with [email protected]: ``` binaryData: [ 176, 174, 201, 207, 82, 101, 98, 101, 99, 99, 97, 45, 178, 169, 191, 205, 163, 172, 214,...

FWIW, both of these work for me when I tried them out in NodeJS ([email protected], [email protected], [email protected]).

One thing that isn't working with this change: https://github.com/benjamn/ast-types/blob/1ea943179ed185fcca1bac606fe8705596935114/src/test/typescript.ts#L23-L29 The glob is no longer matching anything for, I think, two reasons: 1. the `lib` directory is where the file actually...

@benjamn I took a stab at it. It looks like there are a lot of TypeScript files that no longer parse properly. I'm not sure what to do about it...

Thanks for the report. This is happening because the `->` function is being turned into a `function` that has a single statement which is a `return` statement (because CS has...