V1 API: Which should be the default serializer

[rasmus]

With the addition on #848 for v1, there's now an option to switch which is the default. In addition, it might make sense to move e.g. Newtonsoft to a separate NuGet package to minimize the dependencies referenced by the core EventFlow package.

[SeWaS]

Hello there,

If I may ask a question: would you leave the interface IJsonSerializer in the core EventFlow package and then offer two NuGet packages, EventFLow.Newtonsoft and EventFlow.SystemTextJson (for the lack of a better naming), for instance? Or would you go with one package like EventFlow.Serializing which provides the public interface, as well as multiple implementations? Or something in between 😃?

I am just curious about the dependency structure you have in mind. Looking forward to the V1 release!!

[CapitanMurloc]

Hello,

Would having it separate still require us to install it for EventFlow to work properly?

If the answer is yes, isn't it better to leave it as a dependency from EventFlow. You will still end up having to install it anyway, unless you are supporting more than one serialization framework.

Cheers.

[github-actions[bot]]

Hello there!

We hope you are doing well. We noticed that this issue has not seen any activity in the past 90 days. We consider this issue to be stale and will be closing it within the next seven days.

If you still require assistance with this issue, please feel free to reopen it or create a new issue.

Thank you for your understanding and cooperation.

Best regards, EventFlow

[kyle-bradley]

System.Text.Json has matured significantly since this discussion and has become the standard in most projects. I would suggest having it as default with Newtonsoft being a separate package.

[rasmus]

@kyle-bradley definitely! I think I'll properly have it as a required setting, i.e., none selected by default. Then you have to set one or the other. While inconvenient for new projects, it makes it more specific for developers upgrading from 0.x to 1.x. The error message should then have clear instructions on what to do.

[github-actions[bot]]

Hello there!

We hope you are doing well. We noticed that this issue has not seen any activity in the past 90 days. We consider this issue to be stale and will be closing it within the next seven days.

If you still require assistance with this issue, please feel free to reopen it or create a new issue.

Thank you for your understanding and cooperation.

Best regards, EventFlow

[github-actions[bot]]

Hello there!

This issue has been closed due to inactivity for seven days. If you believe this issue still needs attention, please feel free to open a new issue or comment on this one to request its reopening.

Thank you for your contribution to this repository.

Best regards, EventFlow