EventFlow icon indicating copy to clipboard operation
EventFlow copied to clipboard
verified publisher icon eventflow

System.Text.Json support

Open Yaevh opened this issue 4 years ago • 6 comments

System.Text.Json (#678)

Yaevh avatar Jun 02 '21 20:06 Yaevh

Build is broken, I'll have a look

rasmus avatar Jun 09 '21 17:06 rasmus

@rasmus I'ver fixed the tests, can you take a look?

System.Text.Json has two basic limitations compared to Netwonsoft.Json:

  1. System.Text.Json treats empty JSON as invalid and throws JsonException; Newtonsoft.Json deserializes it to null
  2. Newtonsoft.Json can deserialize enum from both int value and name; System.Text.Json handles int value only

As a result, tests of System.Text.Json do not cover all the aspects covered by Newtonsoft.Json. I don't however think that those two features of Newtonsot.Json are used anywhere by EventFlow.

Yaevh avatar Jun 10 '21 16:06 Yaevh

This is great @Yaevh there's still some evaluation if one of the JSON support should be moved to a separate NuGet package (maybe Newtonsoft), but getting this in will make it a whole log easier.

rasmus avatar Jun 17 '21 05:06 rasmus

Regardless of the outcome of #876, could you please merge this PR? We can always extract the code to a different project afterwards, and I'm avaliable to do this if needed :)

BTW, I believe there are no breaking changes in this PR, so maybe we could add System.Text.Json support to V0 already?

Yaevh avatar Jun 17 '21 23:06 Yaevh

I'll have a look

rasmus avatar Jun 28 '21 05:06 rasmus

Regardless if this is added or not, adding the SystemTextJsonSerializer class to your own project is still possible as this operates on public interfaces.

rasmus avatar Jun 28 '21 05:06 rasmus

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still think this pull request is necessary or relevant, please feel free to update it or leave a comment within the next seven days.

Thank you for your contributions and understanding.

Best regards, EventFlow

github-actions[bot] avatar Apr 08 '23 13:04 github-actions[bot]

Hello there! I'm a bot and I wanted to let you know that your pull request has been closed due to inactivity after being marked as stale for seven days. If you believe this was done in error, or if you still plan to work on this pull request, please don't hesitate to reopen it and let us know. We're always happy to review and merge high-quality contributions. Thank you for your interest in our project! Best regards, EventFlow

github-actions[bot] avatar Apr 16 '23 09:04 github-actions[bot]