EventFlow icon indicating copy to clipboard operation
EventFlow copied to clipboard

Published 20 hours ago • verified publisher icon eventflow

WIP: Added event persistence implementation for StreamsDb

Open promontis opened this issue 4 years ago • 4 comments

@pjvds could you review and add a test

promontis avatar Sep 02 '19 09:09 promontis

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 02 '19 09:09 CLAassistant

The tests should as a minimum use TestSuiteForEventStore to make sure that the basics are covered.

rasmus avatar Sep 03 '19 17:09 rasmus

@promontis First of all, thanks for making the effort to write an event store implementation on top of StreamsDB. Very much appreciated!

I've created a pull request that introduces the test project in your fork. This test project is based on the suggestion of @rasmus (thanks for the awesome test set!).

The pull request also has some fixes. If you accept my pull request on your fork, you can test drive the StreamsDB event store in your project.

My pull request updates your develop branch, since EventFlow uses that branch as the trunk. So I would suggest you update this pull request to reflect that change.

See: https://github.com/promontis/EventFlow/pull/1

pjvds avatar Sep 06 '19 20:09 pjvds

The are still 3 things left to do:

  • Support stream deletes (this is blocked by the current beta release of StreamsDB)
  • Add readme and example to the EventFlow.EventStore.StreamsDB project
  • Add the test project to the CI build

pjvds avatar Sep 06 '19 20:09 pjvds

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still think this pull request is necessary or relevant, please feel free to update it or leave a comment within the next seven days.

Thank you for your contributions and understanding.

Best regards, EventFlow

github-actions[bot] avatar Apr 08 '23 13:04 github-actions[bot]

Hello there! I'm a bot and I wanted to let you know that your pull request has been closed due to inactivity after being marked as stale for seven days. If you believe this was done in error, or if you still plan to work on this pull request, please don't hesitate to reopen it and let us know. We're always happy to review and merge high-quality contributions. Thank you for your interest in our project! Best regards, EventFlow

github-actions[bot] avatar Apr 16 '23 09:04 github-actions[bot]