Distinct Command And Documentation

[KoriSeng]

There is discrepancy between the source and the documentation i think.

https://github.com/eventflow/EventFlow/blob/3ae504fdddac3ef66befe524210e393e37e8936e/Source/EventFlow/Commands/DistinctCommand.cs#L35

[rasmus]

@7thcubic in what way? specifically?

[rasmus]

Closing, unsure

[wenkepaul]

@rasmus , The source code has a third type parameter (TExecutionResult) which doesn't exist in the documentation.

Documentation has

public class UserUpdatePasswordCommand : DistinctCommand<UserAggregate, UserId>
{
  // ...
}

And the source code (at least version 0.81.4483) has:

public abstract class DistinctCommand<TAggregate, TIdentity, TExecutionResult> : ICommand<TAggregate, TIdentity, TExecutionResult>
{
  // ...
}

[wenkepaul]

CommandHandler accepts both three and four type parameters. The implementation with three type parameters passes IExecutionResult to the implementation with four type parameters. Could the same be done for DistinceCommand?

public abstract class CommandHandler<TAggregate, TIdentity, TResult, TCommand>

and

public abstract class CommandHandler<TAggregate, TIdentity, TCommand> : CommandHandler<TAggregate, TIdentity, IExecutionResult, TCommand>

[rasmus]

Thanks @wenkepaul for clarifying

[wenkepaul]

If you think following the example from the CommandHandler is the ideal solution, I can implement it.

[github-actions[bot]]

Hello there!

We hope you are doing well. We noticed that this issue has not seen any activity in the past 90 days. We consider this issue to be stale and will be closing it within the next seven days.

If you still require assistance with this issue, please feel free to reopen it or create a new issue.

Thank you for your understanding and cooperation.

Best regards, EventFlow

[github-actions[bot]]

Hello there!

This issue has been closed due to inactivity for seven days. If you believe this issue still needs attention, please feel free to open a new issue or comment on this one to request its reopening.

Thank you for your contribution to this repository.

Best regards, EventFlow