EventFlow icon indicating copy to clipboard operation
EventFlow copied to clipboard

DomainEventPublisher shouldn't stop at exception

Open mbican opened this issue 6 years ago • 1 comments

Since IDomainEventPublisher.PublishAsync() is called after events are already successfully persisted into eventStore all event subscribers should be notified about event. Currently if the first subscriber throws an exception the other subscribers don't receive the event. Better solution would be:

  1. catch exceptions from each subscriber
  2. collect those exception in an array
  3. throw AggregateException() after all subscribers are notified

mbican avatar Mar 16 '19 10:03 mbican

Think this will be a good candidate for 1.0 as it might rely on changing the code significantly.

Considerations

  • I a subscriber throws an exception on the first event, should it still receive the next
  • How should this interact with the IDispatchToSubscriberResilienceStrategy

rasmus avatar Sep 09 '21 17:09 rasmus

Hello there!

We hope you are doing well. We noticed that this issue has not seen any activity in the past 90 days. We consider this issue to be stale and will be closing it within the next seven days.

If you still require assistance with this issue, please feel free to reopen it or create a new issue.

Thank you for your understanding and cooperation.

Best regards, EventFlow

github-actions[bot] avatar Apr 08 '23 13:04 github-actions[bot]

Hello there!

This issue has been closed due to inactivity for seven days. If you believe this issue still needs attention, please feel free to open a new issue or comment on this one to request its reopening.

Thank you for your contribution to this repository.

Best regards, EventFlow

github-actions[bot] avatar Apr 16 '23 09:04 github-actions[bot]