Add domain event publisher to AggregateStore
- Introduced a new private field
_domainEventPublisherinAggregateStoreand updated the constructor to use it directly for publishing domain events, removing the previous service provider retrieval. - Refactored the
CanConvertmethod inSingleValueObjectConverterto use expression-bodied syntax for improved readability while maintaining its original functionality.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: rasmus
:x: AlexGreatDev
AlexGreatDev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Its not possible to add this dependency as it will cause a circular dependency
System.InvalidOperationException : A circular dependency was detected for the service of type 'EventFlow.Aggregates.IAggregateStore'.
[08:38:31 INF] EventFlow.Aggregates.IAggregateStore(EventFlow.Aggregates.AggregateStore) -> EventFlow.Subscribers.IDomainEventPublisher(EventFlow.Subscribers.DomainEventPublisher) -> EventFlow.Sagas.IDispatchToSagas(EventFlow.Sagas.DispatchToSagas) -> EventFlow.Sagas.ISagaStore(EventFlow.Sagas.AggregateSagas.SagaAggregateStore) -> EventFlow.Aggregates.IAggregateStore
Hello there!
We hope this message finds you well. We wanted to let you know that we have noticed that there has been no activity on this pull request for the past 90 days, which makes it a stale pull request.
As a result, we will be closing this pull request within the next seven days. If you still think this pull request is necessary or relevant, please feel free to update it or leave a comment within the next seven days.
Thank you for your contributions and understanding.
Best regards, EventFlow
Hello there! I'm a bot and I wanted to let you know that your pull request has been closed due to inactivity after being marked as stale for seven days. If you believe this was done in error, or if you still plan to work on this pull request, please don't hesitate to reopen it and let us know. We're always happy to review and merge high-quality contributions. Thank you for your interest in our project! Best regards, EventFlow