apkup icon indicating copy to clipboard operation
apkup copied to clipboard

Support for changesNotSentForReview to be able to upload apps in process of review in newer versions play console API

Open ivictbor opened this issue 2 years ago • 4 comments

ivictbor avatar Jun 21 '22 20:06 ivictbor

Not sure why Travis CI fails, locally it seams to be ok:

image

ivictbor avatar Jun 21 '22 21:06 ivictbor

Thanks for the PR!

The Google APIs library has some odd type issues. I'll take a look at that and see if I can solve it.

Could you change the documentation on the parameter to what the parameter actually does rather than what problem it solves?

nprail avatar Jun 27 '22 13:06 nprail

@nprail Thanks for your response and handy package!

I made it after I faced this issue https://github.com/eventOneHQ/apkup/issues/55

To reproduce it you can create any dummy app e.g. using flutter bootstrapper, promote release to all possible levels in play console, request a review from console, and while they will review it try to publish it from apkup.

About doc: yep, I also don't like how I described it, sounds unusual, but thing is that I have no info and was not able to find it in API spec quckly, error just said ERROR: Changes cannot be sent for review automatically. Please set the query parameter changesNotSentForReview to true so I just did it 🤷‍♂️

ivictbor avatar Jun 27 '22 17:06 ivictbor

Ah, yep, just found it here https://developers.google.com/android-publisher/api-ref/rest/v3/edits/commit

ivictbor avatar Jun 27 '22 17:06 ivictbor