evennia icon indicating copy to clipboard operation
evennia copied to clipboard

Refactor CI for postgres

Open ChrisLR opened this issue 2 years ago • 10 comments

Brief overview of PR changes/additions

PSQL tests usually fail after 30 minutes, looking at the actions file I saw the pg version is very outdated.

Motivation for adding to Evennia

Fixing the CI

Other info (issues closed, discussion etc)

ChrisLR avatar Jan 02 '24 16:01 ChrisLR

@Griatch the only change worth keeping so far is using postgres by declaring it in services instead of using another action, it should let us provide a conf to postgres more easily, I did research a few ways to make the tests faster, using one or a few parameters mentioned here

https://www.postgresql.org/docs/current/non-durability.html

However I don't understand why the pg tests would be that slow compared to other databases so I would have to investigate more.

ChrisLR avatar Jan 08 '24 21:01 ChrisLR

Its on the TODO pile, I'll come back to it :sweat_smile:

ChrisLR avatar Jan 08 '24 21:01 ChrisLR

Ping. :)

Griatch avatar Jan 28 '24 14:01 Griatch

@ChrisLR Another ping

Griatch avatar Mar 08 '24 08:03 Griatch

@Griatch Still experimenting, unsure why having the two pg tests run in parallel makes one of them fail while one after the other works

ChrisLR avatar Mar 08 '24 19:03 ChrisLR

@ChrisLR Added Python3.12 to the CI matrix, and the postgres issue remains :disappointed:

Griatch avatar Mar 21 '24 16:03 Griatch

@Griatch using the code from this PR ? :(

ChrisLR avatar Mar 22 '24 00:03 ChrisLR

Nono, just adding a data point since you were looking at this.

Griatch avatar Mar 22 '24 01:03 Griatch

@Griatch :relieved: great, so there's a chance this PR is sufficient, I will add 3.12 to it and see

ChrisLR avatar Mar 22 '24 12:03 ChrisLR

@ChrisLR This is still marked as a Draft. Is this still being worked on?

Griatch avatar Apr 27 '24 15:04 Griatch

@Griatch sorry about the delay, yes this is still on my plate.

ChrisLR avatar May 06 '24 12:05 ChrisLR

No longer worked after resolving conflicts. It likely didn't solve the root issue. Closing for now.

ChrisLR avatar May 16 '24 20:05 ChrisLR