evcc-io
Dev container
Möglichkeit hinzugefügt einen Devcontainer zu starten der die Entwicklung von EVCC auf Windows Systemen erleichtert. Die gitattributes ermöglichen die Nutzung von Git innerhalb des Containers.
I've had a try and couldn't get it to work. It took some 10 minutes to download seemingly a few GB. Starting the container now fails. Not sure how useful this eventually is?
@andig The 10 minute wait is normal when starting for the first time. It is possible to optimise this time by removing the make commands. What error message do you get when starting? Changing the branch when building can also produce errors.
My two cents: For someone who has no idea how to setup a go and node dev env, 10 mins much faster then install all required tools.
@StefanSchoof did you actually try it? Did it help you? It didn't help me, but happy to merge if there is real demand.
As use case I have something like https://github.com/evcc-io/evcc/pull/15348 or an update to docs in mind. Changing the text is something many can, but for running lint and make docs is a thing that needs time to install all deps.
I did a little testing and found some things
- I would remove the make commands. I takes much time and maybe someone may not need it, eg to run
make docs - I think adding the go extension ("golang.go") to the extensions makes sense
- And the imported things:
make docsandmake lintare not working inside this
I think to make this useful this command should be able to run. I had no time to investigate if this is something can be fixed quick.
A make docs works after an make install. So I think having a "postCreateCommand": "make install" makes sense.
Thank you @StefanSchoof for your addition. Does it work the same way for you now? Then @andig could look into the issue again.
Thank you for the work put into this. I do lean to not merging this. Apart from not using dev containers myself (I didn't immediately see how to effectively do so) I do not want to take over responsibility for maintaining the container. It may be a small add-on but as team one that we cannot shoulder. Sorry for not being more supportive in this case.