app icon indicating copy to clipboard operation
app copied to clipboard

F-Droid build failed

Open linsui opened this issue 2 months ago • 10 comments

Recently expo added non-free deps to expo-dev-launcher. https://github.com/expo/expo/commit/5cbd0d43d00b71ee51096f6c01bba969a2b335d1. IIUC, expo-dev-client should only be used for development. Could you please exclude it from release build? Thanks!

linsui avatar Oct 13 '25 08:10 linsui

@linsui Thank you very much for notifying us. A new release with a fix has been released: https://github.com/evcc-io/app/releases/tag/1.1.1

Maschga avatar Oct 15 '25 08:10 Maschga

are you sure you build from a clean terete checked out at the tagged 7b4ede3fd88db70af7f23cb9bbd3b913d60031fe ?

The diff is huge: https://gitlab.com/fdroid/fdroiddata/-/jobs/11722640108#L4100

licaon-kter avatar Oct 15 '25 09:10 licaon-kter

Thank you for your response. I assume the fix did not work.

Maschga avatar Oct 15 '25 11:10 Maschga

Seems like autolinking had a bug which is already fixed: https://github.com/expo/expo/pull/40014 However, this fix has not yet been released: https://github.com/expo/expo/blob/main/packages/expo-modules-autolinking/CHANGELOG.md#unpublished

Maschga avatar Oct 15 '25 18:10 Maschga

How about just removing expo-dev-client in scripts/fdroid/excludeNonfreeDependencies.ts?

linsui avatar Oct 16 '25 06:10 linsui

Your message is a bit ambiguous sicne we're talking about removing/excluding packages. :D

  • If you mean this: expoAutolinking.exclude = ["expo-dev-client"] This way, the build succeeds, but expo-dev-launcher is linked. I don't know if this is okay for F-Droid when removing expo-dev-client.

  • If you mean this: expoAutolinking.exclude = ["expo-dev-launcher"] This way the build fails. expo-dev-client is somehow connected to expo-dev-launcher and needs the expo-dev-launcher package.

Maschga avatar Oct 16 '25 07:10 Maschga

I mean you can just run npm remove expo-dev-client before building the github release. :)

linsui avatar Oct 16 '25 07:10 linsui

I would rather wait for the release so that I don't have to change the pipeline.

Maschga avatar Oct 17 '25 14:10 Maschga

@Maschga is this still an issue?

naltatis avatar Nov 19 '25 07:11 naltatis

Yes.

Maschga avatar Nov 19 '25 08:11 Maschga