F-Droid build failed
Recently expo added non-free deps to expo-dev-launcher. https://github.com/expo/expo/commit/5cbd0d43d00b71ee51096f6c01bba969a2b335d1. IIUC, expo-dev-client should only be used for development. Could you please exclude it from release build? Thanks!
@linsui Thank you very much for notifying us. A new release with a fix has been released: https://github.com/evcc-io/app/releases/tag/1.1.1
are you sure you build from a clean terete checked out at the tagged 7b4ede3fd88db70af7f23cb9bbd3b913d60031fe ?
The diff is huge: https://gitlab.com/fdroid/fdroiddata/-/jobs/11722640108#L4100
Thank you for your response. I assume the fix did not work.
Seems like autolinking had a bug which is already fixed: https://github.com/expo/expo/pull/40014 However, this fix has not yet been released: https://github.com/expo/expo/blob/main/packages/expo-modules-autolinking/CHANGELOG.md#unpublished
How about just removing expo-dev-client in scripts/fdroid/excludeNonfreeDependencies.ts?
Your message is a bit ambiguous sicne we're talking about removing/excluding packages. :D
-
If you mean this:
expoAutolinking.exclude = ["expo-dev-client"]This way, the build succeeds, butexpo-dev-launcheris linked. I don't know if this is okay for F-Droid when removingexpo-dev-client. -
If you mean this:
expoAutolinking.exclude = ["expo-dev-launcher"]This way the build fails.expo-dev-clientis somehow connected toexpo-dev-launcherand needs theexpo-dev-launcherpackage.
I mean you can just run npm remove expo-dev-client before building the github release. :)
I would rather wait for the release so that I don't have to change the pipeline.
@Maschga is this still an issue?
Yes.