Evan Bauer
Evan Bauer
(edited above to fix up a couple of notation things to avoid later confusion) Just noting here also that current velocity `w` and horizontal size `lhat` that we have calculated...
Hmmm, looks like we have another instance of a photo checksum failure without an fpe: https://testhub.mesastar.org/brunt_in_rotation/commits/69b4927/test_cases/star/ppisn I suspect there's something non-trivial going on related to the state of brunt-related quantities.
Actually, it looks like this change is definitely not equivalent to the previous way of doing things. We have a line specifically skipping updates to `s% brunt_N2` during solver iterations:...
Actually, I'm realizing that was probably a red herring, as we don't update mixing info during solver iterations anyway, so it shouldn't matter if the brunt is getting updated during...
@orlox and I discussed working on this some more today. Not clear on what our timeline will be yet, but I think we at least see a path forward that...
The current implementation is based on https://ui.adsabs.harvard.edu/abs/1993ASPC...40..246M/abstract That's derived in the same general picture that we use for the full implementation of the Burgers equations for diffusion, but with some...
Nice find! It seems plausible that the overly restrictive definition was motivated by this particular application, while our output should probably be the simpler more general definition (if I'm following...
Practically, I'm most concerned about falling off Skye near logRho = 10 on this plot. Massive WDs could possibly get there, and falling from Skye to HELM here would likely...