gd2md-html icon indicating copy to clipboard operation
gd2md-html copied to clipboard

[ISSUE-62]: Fix closing li tag, fix nested list

Open FJCrux opened this issue 4 years ago • 7 comments

There is fix for https://github.com/evbacher/gd2md-html/issues/62 You can find google doc with fixed addon version here https://docs.google.com/document/d/1VnPTSkm2AxzR2Up0tBXjRx5vvktaOwgKxLB2tALREh0/edit?usp=sharing

FJCrux avatar Apr 27 '20 18:04 FJCrux

Thanks for attacking the list bugs!

Your fix seems to work on your test file, but it breaks other list cases. Can you test it out on the dev verification file as described here: https://github.com/evbacher/gd2md-html/blob/master/dev.md#modifying-docs-to-markdown-code

Also, let me know if you have any suggestions for simplifying this process. This is my first real open-source project.

evbacher avatar Apr 28 '20 00:04 evbacher

I checked the test files, but I had doubts whether there were problems there:

  1. In case Lists with code blocks, first element must include code block, but code block is not a part list item
  2. In part $ cat file | grep dog | wc html look like wrong even in master branch(

If you meant other cases, please write which ones.

P.S. I will update doc file for your version and update html and md verification for visual comparison

FJCrux avatar Apr 28 '20 11:04 FJCrux

I'll try to get time to take another look at this.

But you'll also need to sign the CLA referred to in CONTRIBUTING.md. I cannot accept code into this repo without that agreement.

evbacher avatar Apr 29 '20 21:04 evbacher

I sign the CLA

FJCrux avatar Apr 30 '20 02:04 FJCrux

@evbacher is there anything I can do to help get this merged?

bravetheheat avatar May 29 '21 17:05 bravetheheat

☝️ ditto! would love this bug fix and am happy to chip in to get it done

pencerw avatar Jul 09 '21 18:07 pencerw

It breaks other test cases, so I am not going to merge. I'll check again and let you know which cases it breaks.

evbacher avatar Jul 09 '21 23:07 evbacher