gd2md-html icon indicating copy to clipboard operation
gd2md-html copied to clipboard

Published 20 hours ago • verified publisher icon evbacher

Add bold and italic delimiter options

Open a2k-hanlon opened this issue 2 years ago • 4 comments

This PR implements #117, the option to encode italic in markdown as *text* instead of _text_, and the option to change the same for bold (**text** or __text__). The UI selectors for these are radio buttons, as shown below:

The default settings follow the existing behaviour: asterisks for bold and underscores for italic.

Here is a link to my copy of the test document: https://docs.google.com/document/d/1buiYxin_Nmre3y_sXQbQGT8UFjsAgypWagoWik-YiQc/edit?usp=sharing

It takes several runs of the tool to check the possible option permutations this PR adds, and changing the options form the default will produce results differing from the markdown-verification.md standard output.

Note, however, that the addon code in this repo seems to be missing a few updates - it is still at v1.0B31 while the verification files indicate v1.0B34, so there are some discrepancies in the output because of this (these discrepancies are unrelated to this change). @evbacher Please update the addon code here on GitHub to the latest version (1.0B34).

a2k-hanlon avatar Jan 08 '23 01:01 a2k-hanlon

@evbacher Thanks for updating the addon code to v1.0B34 in the repo! I have rebased this PR branch on your latest commit (7105e29). The Docs to Markdown sidebar now looks like this with my changes:

image

I have updated the addon code running on my copy of the test google doc linked above and reverified the output. The test google doc you have linked on dev.md still seems to be missing a few things relative to markdown-verification.md, but verifying against the output from the production version of Docs To Markdown on the linked google doc, there are no problems caused by the changes in this PR.

a2k-hanlon avatar Feb 06 '23 06:02 a2k-hanlon

So this never gets implemented? What a shame.

Writingnon avatar Dec 31 '23 07:12 Writingnon

Hey @evbacher, any chance you could take a look at this small feature addition? It has been up for your review for a year :)

a2k-hanlon avatar Jan 02 '24 02:01 a2k-hanlon

Hi @a2k-hanlon -- thanks for this pull request. Sorry it's taken me so long to respond! I have a few other things going on. But I will try to get to it this month. Will contact you if I have any questions.

evbacher avatar Jan 07 '24 16:01 evbacher