Evan Wallace

Results 542 comments of Evan Wallace

Thanks for the report. I am able to reproduce the issue. However, I'm not immediately sure what the right fix is because I haven't touched this code in a long...

The rationale for treating `undefined` this way is that empty functions are often the result of dead code removal where the original function body consists of an if statement. Can...

You're correct that this is not something esbuild does. You could probably figure out something with the plugin API: https://esbuild.github.io/plugins/. I'm imagining something like this: 1. Bundle your code once...

Thanks for reporting this. I have wanted to fix this for a while (and also the similar case for `require`). I agree this isn't great but it's also not a...

> Unless I am missing something or there is a workaround this basically makes it impossible to use esbuild for any react project that makes use of an internal component...

It's possible to implement this with a plugin. You can write an on-load plugin that injects `var __filename = "...some string..."` at the top. > This also applies to `import.meta.url`....

I think my preferred solution for this is going to be to use the `--define` feature in addition to adding the ability for plugins to add additional per-file configuration of...

Do other bundlers support this too? I mainly try to have esbuild follow existing conventions instead of inventing new ones. I don't think esbuild should do something like this without...

It sounds to me like you need to build your app twice, once for the client and once for node, and use a different `publicPath` for each. Building the code...

This PR introduces name collisions into the bundler. Here's an example, which should print `444` when run: ```js import { bar as baz } from 'data:text/javascript,export let bar = 123'...