Evan Wallace

Results 542 comments of Evan Wallace

Data URLs are already URLs. You don't need to convert a data URL into an object URL to be able to use it. Doing that is slower, requires more code,...

This behavior is deliberately done by esbuild so that a) all of the generated code has source map coverage and b) mapping a debugger breakpoint at the beginning of the...

You say this in your source code: ```js // Of course, we could improve this fallback logic by finding the closest segment where segment[0] is less than `sourceCol`, // which...

Comments in expression position are sometimes preserved because some tools that use esbuild to transform code make use of them. These comments are intended for machines, not for humans, and...

Sorry, I don't fully understand. How did this come up? This CI script has been running fine and doesn't appear to be failing.

Thanks for the report. I haven't thought about this case before. I'm wondering if this should be how it works or not. I can see why this could be useful....

> ```js > // the following code will not work. > document.body.style.backgroundImage = `url(${bg})`; > ``` That's true, but it's not clear to me that this is esbuild's fault. There...

Ah so your use case is specifically about string literals. That makes sense and is kind of a cool use case for source maps. I can look at adding support...

Ah, I see. That would be a bigger change then (adding both starting and ending source mappings for all expressions), and could potentially bloat source maps for everyone by quite...

Yes, that's one solution I considered. But people have already been complaining about esbuild already generating multiple chunks and that approach would likely generate way more chunks. So that seems...