Evan Wallace

Results 542 comments of Evan Wallace

I'm closing this because I believe it was fixed by the fix for #4265, which was released in [version 0.25.10](https://github.com/evanw/esbuild/releases/tag/v0.25.10).

Closing this issue as it has been resolved.

> Can I safely update my esbuild in my project without having to read all of the patch notes? First, here's what esbuild currently does: ``` 0.MINOR.PATCH │ │ │...

You should be able to do that with a plugin: https://esbuild.github.io/plugins/#on-resolve

No, sorry. Plugins are the intended way to alter path resolution in esbuild if you have custom requirements like this.

That's strange because esbuild _does_ merge nested source maps, and has for many years (since version 0.6.5). [Here is an example.](https://esbuild.github.io/try/#YgAwLjIzLjAALS1idW5kbGUgLS1zb3VyY2VtYXAAZQBlbnRyeS5qcwBpbXBvcnQgeCBmcm9tICcuL2ZpbGUnCmNvbnNvbGUubG9nKHgpAABmaWxlLmpzAGV4cG9ydCBkZWZhdWx0IC8qIEBfX1BVUkVfXyAqLyBSZWFjdC5jcmVhdGVFbGVtZW50KCJkaXYiLCBudWxsLCB4KTsKLy8jIHNvdXJjZU1hcHBpbmdVUkw9ZGF0YTphcHBsaWNhdGlvbi9qc29uO2Jhc2U2NCxld29nSUNKMlpYSnphVzl1SWpvZ015d0tJQ0FpYzI5MWNtTmxjeUk2SUZzaVBITjBaR2x1UGlKZExBb2dJQ0p6YjNWeVkyVnpRMjl1ZEdWdWRDSTZJRnNpWlhod2IzSjBJR1JsWm1GMWJIUWdQR1JwZGo1N2VIMDhMMlJwZGo0aVhTd0tJQ0FpYldGd2NHbHVaM01pT2lBaVFVRkJRU3hsUVVGbExHOURRVUZETEdGQlFVc3NRMEZCUlRzaUxBb2dJQ0p1WVcxbGN5STZJRnRkQ24wSw) As you can see from the [source map visualization](https://evanw.github.io/source-map-visualization/#NTM3ACgoKSA9PiB7CiAgLy8gZmlsZS5qcwogIHZhciBmaWxlX2RlZmF1bHQgPSAvKiBAX19QVVJFX18gKi8gUmVhY3QuY3JlYXRlRWxlbWVudCgiZGl2IiwgbnVsbCwgeCk7CgogIC8vIGVudHJ5LmpzCiAgY29uc29sZS5sb2coZmlsZV9kZWZhdWx0KTsKfSkoKTsKLy8jIHNvdXJjZU1hcHBpbmdVUkw9ZGF0YTphcHBsaWNhdGlvbi9qc29uO2Jhc2U2NCxld29nSUNKMlpYSnphVzl1SWpvZ015d0tJQ0FpYzI5MWNtTmxjeUk2SUZzaVBITjBaR2x1UGlJc0lDSmxiblJ5ZVM1cWN5SmRMQW9nSUNKemIzVnlZMlZ6UTI5dWRHVnVkQ0k2SUZzaVpYaHdiM0owSUdSbFptRjFiSFFnUEdScGRqNTdlSDA4TDJScGRqNGlMQ0FpYVcxd2IzSjBJSGdnWm5KdmJTQW5MaTltYVd4bEoxeHVZMjl1YzI5c1pTNXNiMmNvZUNraVhTd0tJQ0FpYldGd2NHbHVaM01pT2lBaU96dEJRVUZCTEUxQlFVRXNaVUZCWlN4elFrRkJRU3hqUVVGRExFOUJRVUVzVFVGQlN5eERRVUZGT3pzN1FVTkRka0lzVlVGQlVTeEpRVUZKTEZsQlFVTTdJaXdLSUNBaWJtRnRaWE1pT2lCYlhRcDlDZz09CjIyOQB7InZlcnNpb24iOjMsInNvdXJjZXMiOlsiPHN0ZGluPiIsImVudHJ5LmpzIl0sInNvdXJjZXNDb250ZW50IjpbImV4cG9ydCBkZWZhdWx0IDxkaXY+e3h9PC9kaXY+IiwiaW1wb3J0IHggZnJvbSAnLi9maWxlJ1xuY29uc29sZS5sb2coeCkiXSwibWFwcGluZ3MiOiI7O0FBQUEsTUFBQSxlQUFlLHNCQUFBLGNBQUMsT0FBQSxNQUFLLENBQUU7OztBQ0N2QixVQUFRLElBQUksWUFBQzsiLCJuYW1lcyI6W119),...

That’s very unfortunate. It sounds like a bug with npm. I looked through npm’s issue tracker and found https://github.com/npm/cli/issues/4828, which sounds like what you’re encountering. I wasn’t aware of this...

Doing this would instantly break pretty much all bundling of npm packages, which doesn't seem like a good default behavior. One of the reasons why I had esbuild do this...

Closing as won't fix. Perhaps this was philosophically not the right default, but esbuild is very widely used at this point and I don't think changing this and breaking everyone...

I'm not 100% I understand what you're saying because the issue title mentions `name` but the generated code doesn't use `name` at all. Regardless, I'm closing this issue because a)...