Evan Wallace

Results 417 comments of Evan Wallace

My intent of posting a comment here was to provide one-off feedback instead of being drawn into the spec development process. You are welcome to do what you like with...

This seems like a special-enough case that some form of plugin or custom logic is probably more appropriate. I will think about how to handle this as a plugin. People...

No worries. I plan to extend the plugin API to implement this. I already have it working in one of my branches that contains a rewrite of the linker.

In case it’s helpful: you can do something like this using `--asset-names=` and `[ext]`: https://esbuild.github.io/api/#asset-names

Yes, that's true. This is likely not a bug but a limitation of esbuild's single-pass design. See [this comment](https://github.com/evanw/esbuild/blob/35c263fc4c3d35d7304713ee7a06dda9700da919/internal/js_parser/js_parser_lower.go#L1729-L1755) for an example.

Thanks for the heads up. However, the API is unstable as far as I can tell, and I don't want to build esbuild on top of unstable APIs that could...

Interesting. Some thoughts: * Why does using `loader: { '.json': 'text' }` with `JSON.parse` cause it to be parsed more than once? It seems like that's all you're asking esbuild...

Is there a reason why that package is publishing a `tsconfig.json`?

You can override esbuild's choice of `tsconfig.json` with your own if you want all code in the bundle to use a specific one: https://esbuild.github.io/api/#tsconfig

The compilation model esbuild currently uses is designed to replace the workflow where you run `tsc` to convert TypeScript into JavaScript and then run a bundle to bundle the JavaScript....